Improve migration framework and add migration 101 - Continued#3577
Open
luisa-beerboom wants to merge 10 commits into
Open
Improve migration framework and add migration 101 - Continued#3577luisa-beerboom wants to merge 10 commits into
luisa-beerboom wants to merge 10 commits into
Conversation
…creation, error handling, and introduction of a respective migration with tests.
a9d6d20 to
ed4cb20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #3548
What it is still lacking:
CASCADEto keep it explicit and specific to understand exactly what is being done.additional_viewsinformation (for instance creation ofreal_replace_tables). There is a possibility to store that information analogously in its own column.assert_content_not_none.get_replace_tablesinmigration_helperrelies on that information, we may need specific alterations defined by each migration. One approach could be to set the information in the data definition function or create a function like this analogously to write the information lost into the version table either directly into thereplace_tablescolumn or its own. Another one would be to write such information into a data structure of the migration class. There was also the discussion about creating diffs from yml files.