PyQt5, PyQt6, PySide6 Shim (Switch between different Python bindings for Qt versions)#5885
Merged
PyQt5, PyQt6, PySide6 Shim (Switch between different Python bindings for Qt versions)#5885
Conversation
…nd. Also, adding a new QT version shim, although we aren't using it quite yet.
…ons of PyQt5 and PyQt6. VERY Experimental.
… Both PyQt5 and PyQt6 are now working, except some cursor issues, which seems to get stuck after a drag/drop item operation.
|
Merge conflicts have been detected on this PR, please resolve. |
# Conflicts: # src/windows/add_to_timeline.py # src/windows/animated_title.py # src/windows/export.py # src/windows/main_window.py # src/windows/models/emoji_model.py # src/windows/models/files_model.py # src/windows/models/titles_model.py # src/windows/models/transition_model.py # src/windows/profile_edit.py # src/windows/views/effects_listview.py # src/windows/views/emojis_listview.py # src/windows/views/files_listview.py # src/windows/views/properties_tableview.py # src/windows/views/timeline_backend/qwidget/track.py # src/windows/views/titles_listview.py # src/windows/views/transitions_listview.py
…his might take a few more tries)
…g on a few models (transitions, effects, files)
…t__() across the codebase.
…r a consistent look on all widget libraries).
…ing QPointF correctly, ending QPainter correctly)
…ySide6 compatibility
…Thumbnail view) - since they are single selection only lists
…due to large Arm64 memory addresses (PySide6 forces int() which breaks the pointers in an overflow error)
…erent windows (quite noisy logs)
|
Or the addition of a compile-time flag? Just makes it impossible to package for Nix as the old engine is marked as vulnerable for 24 CVEs :( |
…ng duplication of clips)
… right click context menus
… references), so attempting a fix.
…ltering on our Credits dialog (developers and supporters)
…t preset() image flow. This works a bit differently than our desktop versions.
…ferent than how our desktop works)
…- required some heavy refactoring in qt_api, to hide some of the ugly android implementation details.
…t clobbered along the way
Member
Author
|
We currently support 3 timeline backends: QtWebkit, QtWebEngine, and a custom qwidget built one. The webview backends will soon be removed - as they are only here for legacy reasons now. I wanted to keep them in the 3.5.x releases - but I plan on removing them from develop branch very soon. |
…pi and caused a crash.
…le editor when text lines change
…a few more dialogs)
…changes to launch.py
…larity -> Speech. Once is a model-based denoiser, and one is a upsampler model - both neural networks, both fast, and both great.
…aths are treated as Android URIs. Normal local paths, including Windows drive-letter paths, now resolve to the project’s asset folder again. I also added focused tests for both Windows local paths and content:// URIs.
…al scroll position of the timeline into account, and pasting clips in the wrong track (not the track selected)
…ine did not extend the project's duration to include the newly pasted clips.
…track when vertical scrolling is involved on the timeline.
…them from being pasted a second time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to OpenShot/libopenshot#1027
openshot-qt runtime
OPENSHOT_QT_API.auto: try bindings in order and use the first one that importspyqt6: requires libopenshot to use Qt6pyside6: requires libopenshot to use Qt6pyqt5pyqt6, thenpyside6, thenpyqt5.libopenshot build-time
-DUSE_QT6.AUTO: prefer Qt6 if found, otherwise fall back to Qt5ON: force Qt6OFF: force Qt5