-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/use full urls in env config #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors environment configuration to use full URLs instead of domain-only values. The change improves consistency by having environment variables contain complete URLs with protocols (https://) and optional paths, rather than requiring string concatenation throughout the codebase.
Key changes:
- Environment variables renamed from
*_DOMAINto*_URLformat with full URLs including protocols - Updated URL construction throughout the codebase to use the
URLconstructor for proper path joining - Added utility functions for WebSocket URL conversion and base path extraction from full URLs
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Updated to extract hostname from full URL and validate PUBLIC_SITE_URL |
| svelte.config.js | Added helper functions for WebSocket URL conversion and base path extraction; updated CSP directives to use full URLs |
| src/routes/(anonymous)/+page.server.ts | Updated API configuration to use PUBLIC_BACKEND_API_URL instead of concatenating protocol and domain |
| src/lib/signalr/index.ts | Updated SignalR connection URL construction to use URL constructor with PUBLIC_BACKEND_API_URL |
| src/lib/api/next/base.ts | Simplified URL construction using URL constructor with PUBLIC_BACKEND_API_URL base |
| src/lib/api/index.ts | Updated GetBasePath to validate and return PUBLIC_BACKEND_API_URL directly |
| .env.test | Changed environment variables from domain-only to full URLs with https:// protocol |
| .env.production | Changed environment variables from domain-only to full URLs with https:// protocol |
| .env.development | Changed environment variables from domain-only to full URLs with https:// protocol |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.