fix(webserver): replace full hypertable COUNT with precomputed cml_stats sum#49
Merged
Conversation
…ats sum SELECT COUNT(*) FROM cml_data_secure caused a full sequential scan and chunk decompression on every login, pinning Postgres workers for ~1 min. Replace with SUM(total_records) FROM cml_stats which reads the already- computed per-CML summary table instead.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 82.63% 84.42% +1.78%
==========================================
Files 28 24 -4
Lines 2920 2555 -365
==========================================
- Hits 2413 2157 -256
+ Misses 507 398 -109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overview page called SELECT COUNT(*) FROM cml_data_secure, which triggered a full sequential scan and chunk decompression across the entire compressed TimescaleDB hypertable on every page load, pinning Postgres workers for ~1 minute.
Replace with SELECT COALESCE(SUM(total_records), 0) FROM cml_stats, which reads the pre-aggregated per-CML summary table already maintained by update_cml_stats(). No schema change required.