fix(modules): add missing static/description/index.html for 7 modules#75
fix(modules): add missing static/description/index.html for 7 modules#75
Conversation
Odoo requires static/description/index.html to exist for all modules in the addons path. These 7 modules were missing it, causing FileNotFoundError during module loading.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where several newer Odoo modules were failing to load or install due to the absence of a mandatory Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly identifies and fixes a FileNotFoundError by adding the missing static/description/index.html files for seven modules. While this resolves the immediate issue, the content of these new files is very minimal. My review includes suggestions to enhance these description files by using the module's name and summary from their respective __manifest__.py files and adopting the standard Odoo HTML structure for module descriptions. This will improve the user experience by providing more informative details in the Odoo application list.
| @@ -0,0 +1 @@ | |||
| <h1>spp_aggregation</h1> | |||
There was a problem hiding this comment.
While this file fixes the FileNotFoundError, its content can be improved to align with Odoo's standards for module descriptions. Instead of using the technical module name in a plain <h1> tag, it's better to use the human-readable name and summary from the __manifest__.py file within a structured HTML block. This provides a more informative and user-friendly description in the Odoo Apps interface. Please consider the following suggestion which uses standard Odoo CSS classes for module descriptions.
| <h1>spp_aggregation</h1> | |
| <section class="oe_container"> | |
| <div class="oe_row oe_spaced"> | |
| <h2 class="oe_slogan" style="color:#875A7B;">OpenSPP Aggregation Engine</h2> | |
| <p class="oe_slogan"> | |
| Unified aggregation service for statistics, simulations, and GIS queries | |
| </p> | |
| </div> | |
| </section> |
| @@ -0,0 +1 @@ | |||
| <h1>spp_api_v2_simulation</h1> | |||
There was a problem hiding this comment.
While this file fixes the FileNotFoundError, its content can be improved to align with Odoo's standards for module descriptions. Instead of using the technical module name in a plain <h1> tag, it's better to use the human-readable name and summary from the __manifest__.py file within a structured HTML block. This provides a more informative and user-friendly description in the Odoo Apps interface. Please consider the following suggestion which uses standard Odoo CSS classes for module descriptions.
| <h1>spp_api_v2_simulation</h1> | |
| <section class="oe_container"> | |
| <div class="oe_row oe_spaced"> | |
| <h2 class="oe_slogan" style="color:#875A7B;">OpenSPP Simulation API</h2> | |
| <p class="oe_slogan"> | |
| REST API for simulation scenario management. | |
| </p> | |
| </div> | |
| </section> |
| @@ -0,0 +1 @@ | |||
| <h1>spp_dci_demo</h1> | |||
There was a problem hiding this comment.
While this file fixes the FileNotFoundError, its content can be improved to align with Odoo's standards for module descriptions. Instead of using the technical module name in a plain <h1> tag, it's better to use the human-readable name and summary from the __manifest__.py file within a structured HTML block. This provides a more informative and user-friendly description in the Odoo Apps interface. Please consider the following suggestion which uses standard Odoo CSS classes for module descriptions.
| <h1>spp_dci_demo</h1> | |
| <section class="oe_container"> | |
| <div class="oe_row oe_spaced"> | |
| <h2 class="oe_slogan" style="color:#875A7B;">OpenSPP DCI Demo</h2> | |
| <p class="oe_slogan"> | |
| DCI Demo: Birth Verification for Child Benefit Enrollment | |
| </p> | |
| </div> | |
| </section> |
| @@ -0,0 +1 @@ | |||
| <h1>spp_metrics_core</h1> | |||
There was a problem hiding this comment.
While this file fixes the FileNotFoundError, its content can be improved to align with Odoo's standards for module descriptions. Instead of using the technical module name in a plain <h1> tag, it's better to use the human-readable name and summary from the __manifest__.py file within a structured HTML block. This provides a more informative and user-friendly description in the Odoo Apps interface. Please consider the following suggestion which uses standard Odoo CSS classes for module descriptions.
| <h1>spp_metrics_core</h1> | |
| <section class="oe_container"> | |
| <div class="oe_row oe_spaced"> | |
| <h2 class="oe_slogan" style="color:#875A7B;">OpenSPP Metrics Core</h2> | |
| <p class="oe_slogan"> | |
| Unified metric foundation for statistics and simulations | |
| </p> | |
| </div> | |
| </section> |
| @@ -0,0 +1 @@ | |||
| <h1>spp_metrics_services</h1> | |||
There was a problem hiding this comment.
While this file fixes the FileNotFoundError, its content can be improved to align with Odoo's standards for module descriptions. Instead of using the technical module name in a plain <h1> tag, it's better to use the human-readable name and summary from the __manifest__.py file within a structured HTML block. This provides a more informative and user-friendly description in the Odoo Apps interface. Please consider the following suggestion which uses standard Odoo CSS classes for module descriptions.
| <h1>spp_metrics_services</h1> | |
| <section class="oe_container"> | |
| <div class="oe_row oe_spaced"> | |
| <h2 class="oe_slogan" style="color:#875A7B;">OpenSPP Metrics Services</h2> | |
| <p class="oe_slogan"> | |
| Shared services for fairness, distribution, breakdown, and privacy | |
| </p> | |
| </div> | |
| </section> |
| @@ -0,0 +1 @@ | |||
| <h1>spp_statistic</h1> | |||
There was a problem hiding this comment.
While this file fixes the FileNotFoundError, its content can be improved to align with Odoo's standards for module descriptions. Instead of using the technical module name in a plain <h1> tag, it's better to use the human-readable name and summary from the __manifest__.py file within a structured HTML block. This provides a more informative and user-friendly description in the Odoo Apps interface. Please consider the following suggestion which uses standard Odoo CSS classes for module descriptions.
| <h1>spp_statistic</h1> | |
| <section class="oe_container"> | |
| <div class="oe_row oe_spaced"> | |
| <h2 class="oe_slogan" style="color:#875A7B;">OpenSPP Statistics</h2> | |
| <p class="oe_slogan"> | |
| Publishable statistics based on CEL variables for dashboards, GIS, and APIs | |
| </p> | |
| </div> | |
| </section> |
| @@ -0,0 +1 @@ | |||
| <h1>spp_statistic_studio</h1> | |||
There was a problem hiding this comment.
While this file fixes the FileNotFoundError, its content can be improved to align with Odoo's standards for module descriptions. Instead of using the technical module name in a plain <h1> tag, it's better to use the human-readable name and summary from the __manifest__.py file within a structured HTML block. This provides a more informative and user-friendly description in the Odoo Apps interface. Please consider the following suggestion which uses standard Odoo CSS classes for module descriptions.
| <h1>spp_statistic_studio</h1> | |
| <section class="oe_container"> | |
| <div class="oe_row oe_spaced"> | |
| <h2 class="oe_slogan" style="color:#875A7B;">OpenSPP Statistics Studio</h2> | |
| <p class="oe_slogan"> | |
| Studio UI for managing publishable statistics | |
| </p> | |
| </div> | |
| </section> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 19.0 #75 +/- ##
==========================================
+ Coverage 59.86% 62.18% +2.31%
==========================================
Files 222 268 +46
Lines 12717 16109 +3392
==========================================
+ Hits 7613 10017 +2404
- Misses 5104 6092 +988
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2 participants
Why is this change needed?
Odoo requires
static/description/index.htmlto exist for all modules in the addons path. These 7 newer modules were missing it, causingFileNotFoundErrorduring module loading/installation.How was the change implemented?
Added minimal
static/description/index.htmlfiles to:How to test manually
spp_base) with all addons paths configured — should no longer getFileNotFoundError