Skip to content

feat(spp_change_request_v2): CR UX redesign with stage-based workflow #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emjay0921 wants to merge 12 commits into
base: 19.0
Choose a base branch
from
+3,324 −436

feat(spp_change_request_v2): add skip-to-review button and enforce fi…

bdef7dc
Select commit
Loading
Failed to load commit list.
Open

feat(spp_change_request_v2): CR UX redesign with stage-based workflow #61

feat(spp_change_request_v2): add skip-to-review button and enforce fi…
bdef7dc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 9, 2026 in 1s

69.07% (+0.79%) compared to a3fec68

View this Pull Request on Codecov

69.07% (+0.79%) compared to a3fec68

Details

Codecov Report

❌ Patch coverage is 73.63897% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.07%. Comparing base (a3fec68) to head (bdef7dc).

Files with missing lines Patch % Lines
spp_change_request_v2/models/change_request.py 83.77% 37 Missing ⚠️
...ge_request_v2/models/change_request_detail_base.py 28.57% 15 Missing ⚠️
spp_change_request_v2/details/split_household.py 0.00% 11 Missing ⚠️
spp_change_request_v2/models/dms_file.py 42.10% 11 Missing ⚠️
spp_change_request_v2/wizards/create_wizard.py 62.96% 10 Missing ⚠️
spp_change_request_v2/wizards/revision_wizard.py 40.00% 6 Missing ⚠️
...change_request_v2/wizards/batch_approval_wizard.py 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             19.0      #61      +/-   ##
==========================================
+ Coverage   68.28%   69.07%   +0.79%     
==========================================
  Files         557      635      +78     
  Lines       31666    35771    +4105     
==========================================
+ Hits        21622    24710    +3088     
- Misses      10044    11061    +1017
Files with missing lines Coverage Δ
spp_change_request_v2/__manifest__.py 0.00% <ø> (ø)
spp_change_request_v2/details/add_member.py 80.00% <ø> (ø)
spp_change_request_v2/details/change_hoh.py 64.28% <ø> (ø)
spp_change_request_v2/details/transfer_member.py 65.11% <ø> (ø)
spp_change_request_v2/models/__init__.py 100.00% <100.00%> (ø)
spp_change_request_v2/models/change_request_log.py 100.00% <100.00%> (ø)
...pp_change_request_v2/models/change_request_type.py 66.44% <100.00%> (ø)
spp_change_request_v2/strategies/field_mapping.py 67.94% <100.00%> (ø)
spp_change_request_v2/wizards/__init__.py 100.00% <100.00%> (ø)
...change_request_v2/wizards/batch_approval_wizard.py 33.07% <33.33%> (ø)
... and 6 more

... and 62 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov