Skip to content

Fix mapvtk generating files which can't be used when MTLN is selected #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alberto-o merged 2 commits into from
Apr 15, 2026
Merged

Fix mapvtk generating files which can't be used when MTLN is selected #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd65f52
Fix error in function counting multiwire segments to prepare vtk
Alberto-o Apr 10, 2026
82b2e62
Adds test to check that the vtk can be read
Alberto-o Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src_main_pub/observation.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4896,7 +4896,7 @@ subroutine multiwireBundlesVTK(sgg, init, geom, asigna, conta, i, ii, output, Nt
output(ii)%item(i)%Serialized%eJ(conta) = nj
output(ii)%item(i)%Serialized%eK(conta) = nk

select case (mtln_local%bundles(n)%external_field_segments(m)%direction)
select case (abs(mtln_local%bundles(n)%external_field_segments(m)%direction))
case (iEx)
output(ii)%item(i)%Serialized%currentType(conta) = iJx
output(ii)%item(i)%Serialized%sggMtag(conta) = iabs(tag_numbers%edge%x(ni, nj, nk))
Expand Down
10 changes: 10 additions & 0 deletions test/pyWrapper/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,3 +1227,13 @@ def test_bulk_current_outputs(tmp_path):
assert probeBulkZPlane.direction == 'z'
assert probeBulkYPoint.direction == 'y'

def test_wires_vtk(tmp_path):
fn = CASES_FOLDER + 'wire_vtk/wire_vtk.fdtd.json'

solver = FDTD(input_filename=fn, path_to_exe=SEMBA_EXE, run_in_folder=tmp_path)
solver.run()

vtkmapfile = solver.getVTKMap()
reader = pv.get_reader(vtkmapfile)
mesh = reader.read()
assert mesh.n_cells != 0
Loading
Loading