Skip to content

Fix 32-bit portability issues in NIF code #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinsumner merged 1 commit into from
Feb 23, 2026
+6 −5
Merged

Fix 32-bit portability issues in NIF code #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions c_src/bitcask_nifs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,9 +187,9 @@ typedef struct
// An entry pointer may be tagged to indicate it really points to an
// list of entries with different timestamps. Those are created when
// there are concurrent iterations and updates.
#define IS_ENTRY_LIST(p) ((uint64_t)p&1)
#define GET_ENTRY_LIST_POINTER(p) ((bitcask_keydir_entry_head*)((uint64_t)p&(uint64_t)~1))
#define MAKE_ENTRY_LIST_POINTER(p) ((bitcask_keydir_entry*)((uint64_t)p|(uint64_t)1))
#define IS_ENTRY_LIST(p) ((uintptr_t)p&1)
#define GET_ENTRY_LIST_POINTER(p) ((bitcask_keydir_entry_head*)((uintptr_t)p&(uintptr_t)~1))
#define MAKE_ENTRY_LIST_POINTER(p) ((bitcask_keydir_entry*)((uintptr_t)p|(uintptr_t)1))

// Holds values fetched from a regular entry or a snapshot from an entry list.
typedef struct
Expand Down Expand Up @@ -2494,12 +2494,13 @@ ERL_NIF_TERM bitcask_nifs_file_pwrite(ErlNifEnv* env, int argc, const ERL_NIF_TE
ERL_NIF_TERM bitcask_nifs_file_read(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
{
bitcask_file_handle* handle;
size_t count;
unsigned long count_ul;

if (enif_get_resource(env, argv[0], bitcask_file_RESOURCE, (void**)&handle) &&
enif_get_ulong(env, argv[1], &count)) /* Count */
enif_get_ulong(env, argv[1], &count_ul)) /* Count */
{
ErlNifBinary bin;
size_t count = count_ul;
if (!enif_alloc_binary(count, &bin))
{
return enif_make_tuple2(env, ATOM_ERROR, ATOM_ALLOCATION_ERROR);
Expand Down