Conversation
The ´lossy´ parameter just states if lossy rendering is allowed or not so it's safe to add it to all thumb.php requests. The change should solve rendering issues for JPEG, PNG, TIFF, and possibly other formats.
|
Hi @Abbe98, thanks for working on this. I tested your branch but see no difference in thumbnail rendering - both with the 0.1.1 release of this extension and with this branch I get thumbnails for 53 out of 84 files in this test project: Wikimedia-Commons-files-for-various-tests.openrefine.tar.gz None of the tiff files has a thumbnail in either case. See screenvideos for both versions. Maybe your code change is about other things, in which case I apologize ;-) |
trnstlntk
left a comment
There was a problem hiding this comment.
Makes no difference when testing / comparing with release 0.1.1 - see comment in the PR
The ´lossy´ parameter just states if lossy rendering is allowed or not so it's safe to add it to all thumb.php requests.
The change should solve rendering issues for JPEG, PNG, TIFF, and possibly other formats.