Skip to content

Fix use-after-free in local_dests for DNS-SD discovery (Issue #1531) #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abubakarsabir924-cell wants to merge 4 commits into
base: master
Choose a base branch
from
+16 −2
Open

Fix use-after-free in local_dests for DNS-SD discovery (Issue #1531) #1586

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6aa70f2
Fix INCOMPATIBLE state check in cups_enum_dests() (Issue #1531)
abubakarsabir924-cell May 25, 2026
cf3fd61
Fix use-after-free bug in local_dests (Issue #1531)
abubakarsabir924-cell May 27, 2026
c04387b
Revert "Fix use-after-free bug in local_dests (Issue #1531)"
abubakarsabir924-cell May 27, 2026
a15637b
Fix use-after-free in local_dests using cupsCopyDest (Issue #1531)
abubakarsabir924-cell May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions cups/dest.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3201,8 +3201,8 @@ cups_enum_dests(
// Get the list of local printers and pass them to the callback function...
num_dests = _cupsGetDests(http, IPP_OP_CUPS_GET_PRINTERS, NULL, &dests, data.type, data.mask);

data.num_local = num_dests;
data.local_dests = dests;
data.num_local = 0;
data.local_dests = NULL;

if (data.def_name[0])
{
Expand All @@ -3216,6 +3216,8 @@ cups_enum_dests(

for (i = num_dests, dest = dests; i > 0 && (!cancel || !*cancel); i --, dest ++)
{
data.num_local = cupsCopyDest(dest, data.num_local, &data.local_dests);

cups_dest_t *user_dest; // Destination from lpoptions
const char *device_uri; // Device URI

Expand Down Expand Up @@ -3295,6 +3297,7 @@ cups_enum_dests(
DEBUG_puts("1cups_enum_dests: Unable to create service browser, returning 0.");

cupsFreeDests(data.num_dests, data.dests);
cupsFreeDests(data.num_local, data.local_dests);
cupsArrayDelete(data.devices);

return (false);
Expand All @@ -3315,6 +3318,7 @@ cups_enum_dests(
cupsDNSSDDelete(dnssd);

cupsFreeDests(data.num_dests, data.dests);
cupsFreeDests(data.num_local, data.local_dests);
cupsArrayDelete(data.devices);

return (false);
Expand All @@ -3326,6 +3330,7 @@ cups_enum_dests(
cupsDNSSDDelete(dnssd);

cupsFreeDests(data.num_dests, data.dests);
cupsFreeDests(data.num_local, data.local_dests);
cupsArrayDelete(data.devices);

return (false);
Expand All @@ -3341,6 +3346,7 @@ cups_enum_dests(
cupsDNSSDDelete(dnssd);

cupsFreeDests(data.num_dests, data.dests);
cupsFreeDests(data.num_local, data.local_dests);
cupsArrayDelete(data.devices);

return (false);
Expand All @@ -3352,6 +3358,7 @@ cups_enum_dests(
cupsDNSSDDelete(dnssd);

cupsFreeDests(data.num_dests, data.dests);
cupsFreeDests(data.num_local, data.local_dests);
cupsArrayDelete(data.devices);

return (false);
Expand Down Expand Up @@ -3419,6 +3426,13 @@ cups_enum_dests(

if ((device->type & mask) != type)
device->state = _CUPS_DNSSD_INCOMPATIBLE;

if (device->state == _CUPS_DNSSD_INCOMPATIBLE)
{
DEBUG_printf("2cups_enum_dests: Skipping incompatible '%s'.",
device->fullname);
continue;
}

if (device->state == _CUPS_DNSSD_PENDING)
{
Expand Down
Loading