Skip to content

Move LoRA config to TrainableModel#707

Merged
corbt merged 1 commit into
mainfrom
codex/lora-config
Jun 3, 2026
Merged

Move LoRA config to TrainableModel#707
corbt merged 1 commit into
mainfrom
codex/lora-config

Conversation

@corbt
Copy link
Copy Markdown
Collaborator

@corbt corbt commented Jun 2, 2026

Summary

  • Add top-level TrainableModel.lora_config and public art.LoRAConfig with normalized LoRA field names.
  • Replace _internal_config.peft_args with normalized internal lora_config, and raise a descriptive migration error for legacy peft_args / art.dev.PeftArgs(...) usage.
  • Wire normalized LoRA config through the Megatron trainer, keeping PEFT-shaped names only at PEFT/Unsloth adapter boundaries, and update repo examples/tests.

Tests

  • uv run ruff check src/art/dev/get_model_config.py src/art/dev/model.py src/art/model.py src/art/megatron/lora.py src/art/megatron/service.py src/art/megatron/train.py src/art/unsloth/service.py tests/unit/test_dedicated_config.py examples/hn_title_generator/train.py dev/yes-no-maybe.py
  • uv run pytest tests/unit/test_dedicated_config.py -q
  • uv run ty check src/art/dev/get_model_config.py src/art/dev/model.py src/art/model.py src/art/megatron/lora.py src/art/megatron/service.py src/art/megatron/train.py src/art/unsloth/service.py tests/unit/test_dedicated_config.py
  • commit hooks: ruff, ruff format, ty check src tests, uv lock --check

@corbt corbt force-pushed the codex/lora-config branch from 942434b to 4578c97 Compare June 3, 2026 00:37
@corbt corbt requested review from FurtherAI and bradhilton June 3, 2026 01:15
@corbt corbt marked this pull request as ready for review June 3, 2026 01:50
@corbt corbt merged commit 6ff9f80 into main Jun 3, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants