add Compliance check for staticCodeAnalysis#189
Open
bjohansebas wants to merge 12 commits intoOpenPathfinder:mainfrom
Open
add Compliance check for staticCodeAnalysis#189bjohansebas wants to merge 12 commits intoOpenPathfinder:mainfrom
staticCodeAnalysis#189bjohansebas wants to merge 12 commits intoOpenPathfinder:mainfrom
Conversation
bjohansebas
force-pushed
the
static-code-analysis
branch
from
039c670 to
d42ec8e
Compare
bjohansebas
force-pushed
the
static-code-analysis
branch
from
0aafd27 to
1a8a6ad
Compare
bjohansebas
force-pushed
the
static-code-analysis
branch
from
1a8a6ad to
a8cc1f3
Compare
bjohansebas
commented
Feb 9, 2025
Comment on lines
+109
to
+110
| it.todo('Should generate a pass result if not have public repositories in some organizations') | ||
| it.todo('Should generate a pass result if not have public repositories in all the organizations') |
Contributor
Author
There was a problem hiding this comment.
@UlisesGascon What do you think about displaying a message when an organization has no repositories?
bjohansebas
force-pushed
the
static-code-analysis
branch
from
6ff75b8 to
36ab104
Compare
Contributor
Author
|
Ready to review :) |
…oard into static-code-analysis
Contributor
Author
|
I managed to refactor the function you had created in the previous PR, it was amazing to achieve that. There may be improvements, but I think I did the best I could with the time I have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #83