Minimal CI for OpenPRoT/hubris master#13
Conversation
This disables the attestation in the GH build-one.yml workflow. This is only used in one special case and not currently needed. Signed-off-by: Christian Grönke <christian.groenke@9elements.com>
…0 board(s) The commit limits the default hubris GitHub CI builds to a new `openprot` type. It builds the initial `ast1060` board via the `ast1060-starter` app and the `ast1060-mctp` board via the `ast1060-mctp-echo` app. This is intended to be replaced by different OpenPRoT integrations once this has been worked out. Also, limit to ubuntu-latest build container. Signed-off-by: Christian Grönke <christian.groenke@9elements.com>
…oss modules This commit applies changes to standardize formatting, including indentation and line breaks, across several modules in the repository. This improves code readability and adheres to rust style guidelines. Also, this adds missing license header(s). Note: This uses MPL-2.0 as the license like the rest of the code. Signed-off-by: Christian Grönke <christian.groenke@9elements.com>
|
I spent some time today to try to figure out why I suspect its pulled in via the aspeed-rust stuff, but I am not sure. There was one module I found that didn't disable tests even it was for the target toolchain, but it didn't change anything.. Since the goal right now was to get a minimal CI running to have some sort of CI. I skipped it. It should be investigated by someone with more knowledge here. That should then end in a new PR. |
|
@rusty1968 from the commits I gather the code added (and used) by The refactor patch touches the files that raised Please check I'd open issues for them, but they are disabled in the project. |
|
closing, Hubris usage is deprecated in OpenPRoT |
This PR modifies the upstream hubris CI to build and lint the code.
Following my message here: https://openprot.slack.com/archives/C08QTT3G23X/p1762941476909099
I checked my previous tests and reworked them a bit. The changes needed on the workflow scripts of the upstream project are minimal and shouldn't be a problem.
Testing the build jobs reveals: we need the CI enabled. The code does/did not properly lint (cargo fmt / clippy). Also the license check failed for some code.
The sooner the CI is enabled the better to avoid this in the future.
I did not include the app
ast1060-ecdsa-testandast1060-i2c-scaffoldboth show errors in clippy that point to unused code and other issues. This is (a) no code we are currently working on (b) its not in scope of this PR to fix every CI issue.The boards can be added later via
build-boards.yml:Note:
testaction is disabled. Some of the code added to the repository over the last month pulls oncortex-min the build/test which fails on x86 toolchains.