B #7590: set target bus on disk hotplug#7592
Open
atodorov-storpool wants to merge 1 commit intoOpenNebula:masterfrom
Open
B #7590: set target bus on disk hotplug#7592atodorov-storpool wants to merge 1 commit intoOpenNebula:masterfrom
atodorov-storpool wants to merge 1 commit intoOpenNebula:masterfrom
Conversation
tinova
reviewed
Apr 9, 2026
|
|
||
| VMID="${XPATH_ELEMENTS[j++]}" | ||
| VCPU="${XPATH_ELEMENTS[j++]:-1}" | ||
| SD_DISK_BUS="${XPATH_ELEMENTS[j++]}" |
Member
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
SD_DISK_BUS appears unused. Verify use (or export if used externally).
Contributor
Author
There was a problem hiding this comment.
It is used in vmm/kvm/attach_disk, it is not exported folloing same pattern as all other variables in the function
atodorov-storpool
force-pushed
the
sd_disk_bus
branch
from
6bd7572 to
28e8088
Compare
using SD_DISK_BUS when available. Check if the bus is SATA and raisese error as it is unsupported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
set target bus on disk hotplug using SD_DISK_BUS when available.
Check if the bus is SATA and raise an error as it is unsupported.
Branches to which this PR applies