Skip to content

Conversation

@heathhenley
Copy link
Contributor

Just some minor tweaks I ran into trying to get build running on my environment in Win 11.

  • Check that 7-zip is actually there - I didn't have it installed I guess
  • Use vswhere to find a Visual Studio install to use - the hardcoded version didn't work for me because I have vs professional. The docs suggest that it's available for 2017 and onward.
  • Some of the env variables representing paths were relative, I made them absolute
  • Add a note to the docs about adding the dll to the search path, just like you're already doing in https://github.com/OpenNavigationSurface/BAG/blob/master/python/conftest.py#L5 (I was confused for a while about why I could run the tests but not use bagPy)

Copy link
Collaborator

@selimnairb selimnairb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heathhenley! Just one minor change.

@selimnairb selimnairb merged commit 1b7fbce into OpenNavigationSurface:master Feb 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants