NMS-19492: Fix warnings in EventConfigurationDetail unit tests#8295
Merged
Shahbaz-dataq merged 34 commits intorelease-35.xfrom Feb 26, 2026
Merged
NMS-19492: Fix warnings in EventConfigurationDetail unit tests#8295Shahbaz-dataq merged 34 commits intorelease-35.xfrom
Shahbaz-dataq merged 34 commits intorelease-35.xfrom
Conversation
…-19492-event-conf-warning-fix
synqotik
requested changes
Feb 25, 2026
Contributor
synqotik
left a comment
synqotik
left a comment
There was a problem hiding this comment.
Let's hold off on this. It should just be done on develop, after we added pnpm.
synqotik
approved these changes
Feb 26, 2026
Contributor
synqotik
left a comment
synqotik
left a comment
There was a problem hiding this comment.
Changes look good, let's go ahead and merge. We'll need to check develop that this gets merged cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External References