Skip to content

[com1]: Parallel simulation run with multiple time dep rel files #1278

Merged
fso42 merged 1 commit into
masterfrom
PS_timeDepRelVariation
Jun 1, 2026
Merged

[com1]: Parallel simulation run with multiple time dep rel files #1278
fso42 merged 1 commit into
masterfrom
PS_timeDepRelVariation

Conversation

@PaulaSp3
Copy link
Copy Markdown
Contributor

@PaulaSp3 PaulaSp3 commented May 20, 2026

When using the option time dependent release, for all csv files (in the REL - folder) a simualtion is done, unless a file name is not specified in the ini file.

closes: OpenNHM/DebrisFrame#64

Additionally some minor changes:

  • make the check of the time dependent release values earlier

@PaulaSp3 PaulaSp3 self-assigned this May 20, 2026
@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 20, 2026

Analysis for project AvaFrame

❌ 3 blocking issues (3 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 3

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 20, 2026

Qlty


Coverage Impact

⬇️ Merging this pull request will decrease total coverage on master by 0.01%.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA58.8%

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
avaframe/in1Data/getInput.py77.8%230-232, 306...
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py70.0%3359-3364
Coverage rating: D Coverage rating: F
avaframe/com1DFA/debrisFunctions.py66.7%175
Coverage rating: B Coverage rating: C
avaframe/com1DFA/deriveParameterSet.py25.0%439-441
Total73.8%
🤖 Increase coverage with AI coding...
In the `PS_timeDepRelVariation` branch, add test coverage for this new code:

- `avaframe/com1DFA/com1DFA.py` -- Line 3359-3364
- `avaframe/com1DFA/debrisFunctions.py` -- Line 175
- `avaframe/com1DFA/deriveParameterSet.py` -- Line 439-441
- `avaframe/in1Data/getInput.py` -- Lines 230-232, 306, 516-518, 577-579, and 1237-1240

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@PaulaSp3 PaulaSp3 requested review from JuLa96, awirb and fso42 and removed request for awirb and fso42 May 20, 2026 17:23
Comment thread avaframe/in1Data/getInput.py Outdated
@PaulaSp3 PaulaSp3 requested review from awirb and fso42 May 21, 2026 15:07
Comment thread avaframe/in1Data/getInput.py Outdated
Comment thread avaframe/in1Data/getInput.py Outdated
Comment thread avaframe/in1Data/getInput.py Outdated
Comment thread avaframe/in1Data/getInput.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
@PaulaSp3 PaulaSp3 requested a review from fso42 May 26, 2026 12:16
Comment thread avaframe/in1Data/getInput.py Outdated
@fso42 fso42 removed the request for review from awirb May 27, 2026 13:23
@PaulaSp3 PaulaSp3 requested a review from awirb May 27, 2026 13:58
@PaulaSp3 PaulaSp3 assigned fso42 and unassigned PaulaSp3 Jun 1, 2026
…ulations runs

update docu

fix bug, allow specifying timedependent release scenario in cfg file, work with scenario names instead of file paths

check if chosen release scenario is available is earlier now
@fso42 fso42 force-pushed the PS_timeDepRelVariation branch from 05efde5 to a4476eb Compare June 1, 2026 08:54
@fso42
Copy link
Copy Markdown
Contributor

fso42 commented Jun 1, 2026

Standardtests ident apart from known com5

@fso42 fso42 merged commit ec75b89 into master Jun 1, 2026
4 checks passed
@fso42 fso42 deleted the PS_timeDepRelVariation branch June 1, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to start multiple simulations with varying csv - files (time dependent release files)

3 participants