Skip to content

[com1], [out1], [doc]: Add timeInfo #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fso42 merged 1 commit into from
Dec 15, 2025
Merged

[com1], [out1], [doc]: Add timeInfo #1217

fso42 merged 1 commit into from
Dec 15, 2025

Conversation

@awirb
Copy link
Contributor

@awirb awirb commented Dec 9, 2025

  • add timeInfo as result type
  • add unit to outPlotAllPeak plots (used for com1DFA report)

@awirb awirb requested a review from fso42 December 9, 2025 09:27
@awirb awirb self-assigned this Dec 9, 2025
@qltysh
Copy link
Contributor

qltysh bot commented Dec 9, 2025 •
edited
Loading

1 new issue

Tool Category Rule Count
qlty Duplication Found 21 lines of similar code in 2 locations (mass = 80) 1

qltysh[bot]
qltysh bot reviewed Dec 9, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Dec 9, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Dec 9, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Dec 9, 2025
View reviewed changes
@qltysh
Copy link
Contributor

qltysh bot commented Dec 9, 2025 •
edited
Loading

Qlty

Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.04%.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA100.0%

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py100.0%
Coverage rating: A Coverage rating: A
avaframe/out3Plot/plotUtils.py100.0%
Coverage rating: B Coverage rating: B
avaframe/com1DFA/deriveParameterSet.py100.0%
Coverage rating: A Coverage rating: A
avaframe/com1DFA/com1DFATools.py100.0%
Coverage rating: B Coverage rating: B
avaframe/out1Peak/outPlotAllPeak.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@awirb awirb changed the title Add timeInfo [com1], [out1], [doc]: Add timeInfo Dec 9, 2025
fso42
fso42 requested changes Dec 9, 2025
View reviewed changes
@fso42 fso42 added the enhancement New feature or request label Dec 9, 2025
qltysh[bot]
qltysh bot reviewed Dec 10, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Dec 10, 2025
View reviewed changes
@awirb awirb requested a review from fso42 December 10, 2025 15:52
fso42
fso42 approved these changes Dec 10, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Dec 11, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Dec 11, 2025
View reviewed changes
@awirb awirb requested a review from fso42 December 11, 2025 08:33
@awirb awirb assigned fso42 and unassigned awirb Dec 11, 2025
qltysh[bot]
qltysh bot reviewed Dec 11, 2025
View reviewed changes
qltysh[bot]
qltysh bot reviewed Dec 11, 2025
View reviewed changes
@fso42 fso42 assigned awirb and unassigned fso42 Dec 15, 2025
qltysh[bot]
qltysh bot reviewed Dec 15, 2025
View reviewed changes
@fso42 fso42 assigned fso42 and unassigned awirb Dec 15, 2025
@awirb @fso42
(com1) add timeInfo resType
e32bf4b 
add info in docs

add discrete colormap option and units to colorbar

add pytests

fix small issues

add label to plot colorbar

update docu

update pytest

remove unused import

add timeInfo to resTpyes
qltysh[bot]
qltysh bot reviewed Dec 15, 2025
View reviewed changes
@fso42
Copy link
Contributor

fso42 commented Dec 15, 2025

Standardtests ident

@fso42 fso42 merged commit 7419867 into master Dec 15, 2025
4 checks passed
@fso42 fso42 deleted the addFrontType branch December 15, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

@fso42 fso42 fso42 approved these changes

Assignees

@fso42 fso42

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awirb @fso42