Skip to content

Conversation

@PaulaSp3
Copy link
Contributor

@PaulaSp3 PaulaSp3 commented Nov 25, 2025

Example plot for mass sources:
massSource_hydrKot_8574457310_C_S_entres_dfa

@qltysh
Copy link
Contributor

qltysh bot commented Nov 25, 2025

❌ 3 blocking issues (4 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 2
ruff Lint Redefinition of unused test\_updateInitialVelocity from line 1008 1
qlty Structure Function with high complexity (count = 10): prepareReleaseEntrainment 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

@PaulaSp3 PaulaSp3 removed request for awirb and fso42 November 28, 2025 09:38
@PaulaSp3 PaulaSp3 changed the title [com1]: hydrograph (general release option) for timestep 0 [com1]: time dependet release option (hydrograph) for timestep 0 Dec 11, 2025
@PaulaSp3 PaulaSp3 changed the title [com1]: time dependet release option (hydrograph) for timestep 0 [com1]: time dependent release option (hydrograph) for timestep 0 Dec 11, 2025
Co-authored-by: qltysh[bot] <168846912+qltysh[bot]@users.noreply.github.com>
assert np.isclose(particlesTest[key], particlesVelocity[key], atol=1e-3)


def test_updateInitialVelocity():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redefinition of unused test_updateInitialVelocity from line 1008 [ruff:F811]

for vel in timeDepRelValues["velocity"]:
if vel < 0:
message = "The initial velocity provided in %s can not be negative." % (timeDepRelCsv)
log.error(message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 11): checkTimeDepRelease [qlty:function-complexity]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants