[com1],[doc]: correct docu for raster inputs #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fso42 merged 2 commits into master from PS_doc

Dec 9, 2025

Contributor

PaulaSp3 commented Nov 20, 2025 •

edited by awirb

Loading

flag thicknessFromShp does not exist any more
in point 3 (Via release thickness file): I'm not sure, how it is correct

code changes:

allow for no data values in raster input files (release, etc) if also no data values in DEM at respective locations
if nans due to remeshing to match DEM cell size, ignore those nan values

PaulaSp3 requested review from awirb and fso42

November 20, 2025 17:20

PaulaSp3 self-assigned this

PaulaSp3 added the documentation label

awirb approved these changes

View reviewed changes

Contributor

qltysh bot commented Nov 24, 2025 •

edited

Loading

Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.04%.

Modified Files with Diff Coverage (1)

Rating	File	% Diff	Uncovered Line #s
	avaframe/com1DFA/deriveParameterSet.py	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

fso42 requested changes

View reviewed changes

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

awirb requested a review from fso42

November 24, 2025 16:09

PaulaSp3 commented

View reviewed changes

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

docs/moduleCom1DFA.rst Outdated Show resolved Hide resolved

PaulaSp3 assigned awirb and unassigned PaulaSp3

fso42 approved these changes

View reviewed changes

Contributor

qltysh bot commented Dec 1, 2025 •

edited

Loading

All good ✅

qltysh bot reviewed

View reviewed changes

avaframe/com1DFA/deriveParameterSet.py Outdated Show resolved Hide resolved

avaframe/tests/test_deriveParameterSet.py Outdated Show resolved Hide resolved

qltysh bot reviewed

View reviewed changes

avaframe/com1DFA/deriveParameterSet.py Outdated Show resolved Hide resolved

avaframe/tests/test_deriveParameterSet.py Outdated Show resolved Hide resolved

awirb requested a review from fso42

December 1, 2025 10:03

qltysh bot reviewed

View reviewed changes

avaframe/com1DFA/deriveParameterSet.py Outdated Show resolved Hide resolved

avaframe/tests/test_deriveParameterSet.py Outdated Show resolved Hide resolved

qltysh bot reviewed

View reviewed changes

avaframe/com1DFA/deriveParameterSet.py Outdated Show resolved Hide resolved

avaframe/tests/test_deriveParameterSet.py Outdated Show resolved Hide resolved

fso42 requested changes

View reviewed changes

Contributor

fso42 left a comment

2 points from me, and the qlty comments should be addressed as well

avaframe/com1DFA/deriveParameterSet.py Show resolved Hide resolved

avaframe/com1DFA/com1DFACfg.ini Outdated Show resolved Hide resolved

fso42 approved these changes

View reviewed changes

awirb requested a review from fso42

December 9, 2025 09:40

awirb assigned fso42 and unassigned awirb

fso42 approved these changes

View reviewed changes

fso42 force-pushed the PS_doc branch from 230442d to e795fd5 Compare

December 9, 2025 14:30

PaulaSp3 and others added 2 commits

December 9, 2025 15:31


          correct documetation

f37be35

todo comment

update input data type com1DFA

add comment about nodata values

add either or

tests/test_deriveParameterSet.py

change layout

add comments

add more info


          Pin cython due to problems with numpy 2.0

eb9f7b4

fso42 force-pushed the PS_doc branch from e795fd5 to eb9f7b4 Compare

December 9, 2025 14:31

Contributor

fso42 commented Dec 9, 2025

Standardtests ident

fso42 merged commit 7663c31 into master

4 checks passed

fso42 deleted the PS_doc branch

December 9, 2025 14:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels