[com1;in2] Add tiff compression; adjust particles export logic #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
fso42
changed the title
fso42
force-pushed
the
addTiffCompression
branch
from
9e40e5b to
78fb368
Compare
fso42
force-pushed
the
addTiffCompression
branch
from
00e61b1 to
db4e5a6
Compare
fso42
force-pushed
the
addTiffCompression
branch
2 times, most recently
from
8802afa to
f43f342
Compare
Contributor
❌ 2 blocking issues (2 total)
@qltysh one-click actions:
|
fso42
force-pushed
the
addTiffCompression
branch
from
9e949c1 to
225fea4
Compare
fso42
force-pushed
the
addTiffCompression
branch
from
428b2f0 to
1a19d9c
Compare
PaulaSp3
approved these changes
Nov 18, 2025
ahuber-bfw
approved these changes
Nov 18, 2025
awirb
reviewed
Nov 18, 2025
awirb
approved these changes
Nov 18, 2025
fso42
force-pushed
the
addTiffCompression
branch
from
a3b9083 to
eb6265b
Compare
Contributor
|
Diff Coverage: The code coverage on the diff in this pull request is 85.7%. Total Coverage: This PR will decrease coverage by 0.02%. File Coverage Changes
🛟 Help
|
Contributor
Author
|
Standardtests ident |
refactor(rasterUtils, deriveParameterSet): simplify compression logic and reformat function call - Updated compression logic in `writeResultToRaster` to initialize `extraKwargs` more clearly. refactor(com1DFA): remove redundant raster output logic in `updateResCoeffFields` refactor(com1DFA): simplify `updateResCoeffFields` function and remove unused parameters - Removed unused `t` and `dem` parameters from `updateResCoeffFields` function to streamline its interface. - Updated all references to `updateResCoeffFields` across `com1DFA` and related test files. feat(rasterUtils): add optional compression parameter for raster writing - Introduced `useCompression` parameter to `writeResultToRaster` for configurable compression of `GTiff` files. - Defaulted the parameter to `True` for LZW compression refactor(rasterUtils): simplify raster file writing logic and enforce driver validation; fixes #1163 - Added validation to ensure only supported drivers (`AAIGrid`, `GTiff`) are used. - Utilized `with` statement to handle file writing safely and cleanly. - Implemented LZW compression for `GTiff` raster outputs to optimize file size. - Refactored file writing logic to support driver-specific configurations. refactor(com1DFA): remove unnecessary blank line from configuration file - Introduced `useCompression` parameter in `EXPORTS` config to enable LZW compression for raster outputs. - Updated `writeResultToRaster` calls across modules to support optional compression. - Adjusted tests and added relevant configuration for validation. PROBLEM WITH updateResCoeffFields -> only cfg General is supplied, not Exports
fso42
force-pushed
the
addTiffCompression
branch
from
eb6265b to
5a75bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the compression:
Each module should implement a useCompression in their cfg IF they want to turn off compression in the case of tiff usage. (done for com1DFA)
By default compression is used!