Skip to content

Conversation

@awirb
Copy link
Contributor

@awirb awirb commented Dec 19, 2024

spatialVoellmy friction model:

  • check if provided mu, xi fields are of same extent as computational domain (defined by DEM and meshCellSize (com1DFACfg.ini) using a threshold of resizeThreshold (found in com1DFACfg.ini) x meshCellSize (com1DFACfg.ini)
  • if mu, xi fields become projected onto computational mesh - provide warning
  • if extent not within resizeThreshold x meshCellSize meters of computational DEM - error

@awirb awirb requested a review from fso42 December 19, 2024 10:19
@pep8speaks
Copy link

pep8speaks commented Dec 19, 2024

Hello @awirb! Thanks for updating this PR.

Line 157:121: E501 line too long (130 > 120 characters)
Line 135:121: E501 line too long (124 > 120 characters)
Line 123:121: E501 line too long (127 > 120 characters)
Line 121:121: E501 line too long (127 > 120 characters)
Line 118:121: E501 line too long (140 > 120 characters)

Line 2875:121: E501 line too long (132 > 120 characters)
Line 1310:59: E251 unexpected spaces around keyword / parameter equals
Line 1310:57: E251 unexpected spaces around keyword / parameter equals
Line 1310:51: E231 missing whitespace after ','
Line 1128:121: E501 line too long (125 > 120 characters)
Line 1126:56: E231 missing whitespace after ','
Line 1125:40: E711 comparison to None should be 'if cond is None:'

Line 913:121: E501 line too long (122 > 120 characters)
Line 898:80: E225 missing whitespace around operator
Line 898:49: E225 missing whitespace around operator
Line 896:80: E225 missing whitespace around operator
Line 896:49: E225 missing whitespace around operator
Line 802:1: E302 expected 2 blank lines, found 1
Line 743:121: E501 line too long (130 > 120 characters)
Line 334:121: E501 line too long (126 > 120 characters)
Line 334:85: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
Line 286:121: E501 line too long (132 > 120 characters)
Line 259:30: E225 missing whitespace around operator
Line 119:121: E501 line too long (128 > 120 characters)
Line 76:121: E501 line too long (127 > 120 characters)

Line 660:15: E231 missing whitespace after ','
Line 658:21: E127 continuation line over-indented for visual indent
Line 657:17: E225 missing whitespace around operator
Line 642:15: E231 missing whitespace after ','
Line 622:14: E231 missing whitespace after ','
Line 620:31: E127 continuation line over-indented for visual indent
Line 247:121: E501 line too long (121 > 120 characters)
Line 15:1: E302 expected 2 blank lines, found 1

Comment last updated at 2025-01-10 09:49:54 UTC

@fso42 fso42 added the enhancement New feature or request label Dec 19, 2024
@fso42 fso42 changed the title update check for extent of mu, xi fields update check for extent of mu, xi fields [com1] Dec 19, 2024
@fso42 fso42 self-assigned this Jan 10, 2025
  - add check for RELTH file
  - add if only when requiredto read DEM
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit b121fbd and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 2
Duplication 8

The test coverage on the diff in this pull request is 74.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.5% (0.0% change).

View more on Code Climate.

@fso42
Copy link
Contributor

fso42 commented Jan 10, 2025

Standardtests ok, apart from know kot hof

@fso42 fso42 merged commit e204c7b into master Jan 10, 2025
4 checks passed
@fso42 fso42 deleted the addCheck branch January 10, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants