Skip to content

Conversation

@PaulaSp3
Copy link
Contributor

Added docstrings to function.

  • I almost didn't change existing docstrings/ documentation
  • I'm not sure how to document the object methods properly (flowClass.py)

@PaulaSp3 PaulaSp3 added the documentation Improvements or additions to documentation label Sep 25, 2024
@pep8speaks
Copy link

pep8speaks commented Sep 25, 2024

Hello @PaulaSp3! Thanks for updating this PR.

Line 537:13: E265 block comment should start with '# '
Line 536:13: E265 block comment should start with '# '
Line 332:121: E501 line too long (121 > 120 characters)

Line 120:5: E722 do not use bare 'except'
Line 111:5: E722 do not use bare 'except'
Line 86:5: E722 do not use bare 'except'

Comment last updated at 2024-12-04 10:29:50 UTC

@fso42
Copy link
Contributor

fso42 commented Sep 25, 2024

@PaulaSp3: This is where the docstring ends up: https://docs.avaframe.org/en/latest/_autosummary/com4FlowPy.flowClass.Cell.html#com4FlowPy.flowClass.Cell .
Looking at it, I think if you specifiy the input after the "constructor for the cell..." bit, you should be fine....

@PaulaSp3 PaulaSp3 force-pushed the PS_FP_docstrings branch 2 times, most recently from 9dac278 to 75cd18c Compare November 6, 2024 09:42
lwdtirol and others added 2 commits December 4, 2024 11:29
docstrings

add docstings

add docstrin

pep8

bring docstrings in consistent format

pep8

pep8

minor docu changes

minor docu changes
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 1bd5104 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.5%.

View more on Code Climate.

@PaulaSp3 PaulaSp3 closed this Dec 4, 2024
@PaulaSp3 PaulaSp3 deleted the PS_FP_docstrings branch December 4, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants