-
-
Notifications
You must be signed in to change notification settings - Fork 5
Fix/Finish initial song search implementation #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be subtle. :]
Partially revers commit 0de0449.
It's not the focus, the content is - we can make it as simple and unobtrusive as possible.
Removed loading overlay appearing during a filter or query change. Removed separate skeleton loading component tree in favor of making each leaf component aware of its state and capable of displaying itself as a skeleton (WIP), as recommended by `react-loading-skeleton`. See: https://github.com/dvtng/react-loading-skeleton#dont-make-dedicated-skeleton-screens
Makes it consistent with 'My songs'.
(shh... don't tell anyone... but... the three dots icon already serves this purpose!!)
We've had Next.js complain about importing tons of stuff from the `@nbw/database` module into the client bundle, even though we already imported `SongPreviewDtoType` from that package before. I've decided to inline the enums and add a TODO so we can look deeper into that issue later. That's still better than going back to the magic strings :)
Replaces and combines the functionality of methods `getSongsByCategory`, `getRecentSongs` and `searchSongs` into a generic `querySongs` method that supports all parameters.
The up-pointing arrows had to be read bottom-up, which was counterintuitive.
This was
linked to
issues
Dec 31, 2025
Closed
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request implements all changes detailed in #67, effectively concluding the implementation of #44.
Closes #44, closes #67
Notes
Changes
Search bar
type=search, displaying a conventional clear button in WebKit browsers.Search page
asc,title) in favor of importing the project-wide enum definitions (SongOrderType.ASC,SongSortType.TITLE).Song API
SongServicemethods with a singlequerySongsmethod, which features:recent,random,play-count,note-count,title,duration)asc,desc)category)page,limit)Database
stats.durationstats.noteCountvisibility+createdAt(compound)category+createdAt(compound)playCountskipped due to updating very oftenOther changes
These should have been committed separately but they have been revamped mostly as part of necessary changes, so they have also been included here.
"bradlc.vscode-tailwindcss,fill-labs.dependiandgruntfuggly.todo-treeas recommended extensions.*.cssand*.scssfiles with Tailwind CSS so VS Code properly recognizes directives such as@apply.globals.cssstylesheet to their Tailwind classes.group-hover).