Fix signal filter regex matching in ComponentTable (v2.1)#1585
Open
AxelMatstoms wants to merge 1 commit intoOpenModelica:maintenance/v2.1from
Open
Fix signal filter regex matching in ComponentTable (v2.1)#1585AxelMatstoms wants to merge 1 commit intoOpenModelica:maintenance/v2.1from
AxelMatstoms wants to merge 1 commit intoOpenModelica:maintenance/v2.1from
Conversation
In ComponentFMUCS, ComponentFMUME the regex in addSignalsToResults and removeSignalsFromResults is matched against the full cref of the signal, e.g. model.root.component.signal. In ComponentTable, the regex was matched against the signal name only. This commit fixes this inconsistency by updating the ComponentTable implementations to match against the full cref of the signal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#1584
Purpose
In ComponentFMUCS, ComponentFMUME the regex in addSignalsToResults and removeSignalsFromResults is matched against the full cref of the signal, e.g. model.root.component.signal. In ComponentTable, the regex was matched against the signal name only.
Approach
This PR fixes this inconsistency by updating the ComponentTable implementations to match against the full cref of the signal.