Skip to content

Add Windows app download button to quickstart page#22

Merged
t0mdavid-m merged 1 commit into
mainfrom
claude/add-windows-download-button-MkQvX
Apr 29, 2026
Merged

Add Windows app download button to quickstart page#22
t0mdavid-m merged 1 commit into
mainfrom
claude/add-windows-download-button-MkQvX

Conversation

@t0mdavid-m
Copy link
Copy Markdown
Member

@t0mdavid-m t0mdavid-m commented Apr 29, 2026

Summary

Added functionality to the quickstart page to allow users to download a Windows version of the OpenMS application directly from the Streamlit interface.

Key Changes

  • Imported Path from pathlib for file system operations
  • Created a cached resource function load_windows_app_bytes() that reads the Windows app binary from /app/OpenMS-App.zip if it exists
  • Added a Streamlit download button on the main quickstart page that displays when the Windows app file is available
  • The download button is styled with a material download icon and serves the file with the correct MIME type

Implementation Details

  • Used @st.cache_resource decorator to cache the app bytes in memory, avoiding repeated file reads
  • The function gracefully returns None if the app file doesn't exist, preventing errors in environments where the Windows app isn't available
  • The download button only renders when the app file is present, ensuring a clean UI in all deployment scenarios

https://claude.ai/code/session_01QmHobjk1tgB7i5iGY5fAoE

Summary by CodeRabbit

  • New Features
    • Quickstart page now features conditional download functionality for the OpenMS-App ZIP artifact. When the artifact is available on the system, users can directly download the ZIP file from the quickstart interface. If unavailable, the download option is hidden, maintaining a clean user experience without unnecessary UI elements.

Serve the bundled OpenMS-App.zip (downloaded into /app by the Dockerfile)
as a cached, server-wide resource via st.download_button on the
DDA-LFQ quickstart page. The button is hidden when the asset is not
present (e.g. local dev runs without the bundled build).
@t0mdavid-m t0mdavid-m merged commit ff5ce66 into main Apr 29, 2026
5 of 6 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The quickstart page now includes conditional rendering of a download button for OpenMS-App.zip. A cached loader attempts to read a Windows ZIP artifact from a fixed filesystem path, and the download UI is displayed only if the artifact is successfully loaded.

Changes

Cohort / File(s) Summary
Quickstart Download Feature
content/quickstart.py
Added Path import and implemented a cached loader that reads a Windows ZIP artifact from the filesystem. Conditionally renders a download button for OpenMS-App.zip when the artifact is available.

Poem

🐰 A button hops onto the page so bright,
When ZIP files hide on the filesystem's sight,
With caching and checks, the artifact's found—
Download awaits, no error's around! 📦

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding a Windows app download button to the quickstart page. It is concise, specific, and directly reflects the primary purpose of the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/add-windows-download-button-MkQvX

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants