Rename Mission.Design variables to Aircraft.Design

[cmbenne3]

Summary

This PR changes the names of Mission.Design.XXX to Aircraft.Design.XXX and removes some unnecessary variables.

class Mission.Design:	New Variable Name	Notes
Mission.Design.CRUISE_ALTITUDE = 'mission:design:cruise_altitude'	Aircraft.Design.CRUISE_ALTITUDE = 'aircraft:design:cruise_altitude'	This variable is only used to calculate max mach for GASP-based Mass in design_load.py It has hardcoded atmospheric constants and should be updated to use Aviary's atmospheric subsystem Issue #1039 .
Mission.Design.CRUISE_RANGE = 'mission:design:cruise_range'	N/A	Removed as not used anywhere in codebase
Mission.Design.GROSS_MASS = 'mission:design:gross_mass'	Aircraft.Design.GROSS_MASS = 'aircraft:design:gross_mass'	We update this to Aircraft since it makes no sense to track the design mission gross mass under mission.
Mission.Design.LIFT_COEFFICIENT = 'mission:design:lift_coefficient'	Aircraft.Design.LIFT_COEFFICIENT = 'aircraft:design:lift_coefficient'	This is not actively set by any of our models, but can be used to overwrite the value clculated by EDET if desired
Mission.Design.LIFT_COEFFICIENT_MAX_FLAPS_UP = 'mission:design:lift_coefficient_max_flaps_up'	Aircraft.Design.LIFT_COEFFICIENT_MAX_FLAPS_UP = 'aircraft:design:lift_coefficient_max_flaps_up'	Currently only specified in GwFm... but seems to be an input to gasp aero...?
Mission.Design.MACH = 'mission:design:mach'	Aircraft.Design.MACH = 'aircraft:design:mach'	This is an aircraft Design Variable, mission mach can be updated in phase info
Mission.Design.RANGE = 'mission:design:range'	Aircraft.Design.RANGE = 'aircraft.design.range'	This is really an aircraft design variable used to size flops subsystems. It is used as an initial guess for target range when not set in phase info
RATE_OF_CLIMB_AT_TOP_OF_CLIMB = 'mission:design:rate_of_climb_at_top_of_climb'	N/A	Variable removed as not used anywhere in Aviary. We should add an example or document how a user would apply a minimum top of climb climb rate constraint as this is a common constraint to have in aircraft design. Issue #1037 tracks this
Mission.Design.RESERVE_FUEL = 'mission:design:reserve_fuel'	Mission.RESERVE_FUEL = 'mission:reserve_fuel'	This is moved under Mission directly as it is not a design variable. As the sum of Mission.RESERVE_FUEL_BURNED + Aircraft.Design.RESERVE_FUEL_ADDITIONAL + Aircraft.Design.RESERVE_FUEL_MARGIN it must be allowed to vary depending on the reserve mission being modelled. Fuel additional and fuel margin are design variables assigned at the aircraft level
Mission.Design.THRUST_TAKEOFF_PER_ENG = 'mission:design:thrust_takeoff_per_eng'	Aircraft.Design.THRUST_TAKEOFF_PER_ENG = 'aircraft:design:thrust_takeoff_per_eng'	This is only used for height energy simple takeoff. By default it should probably be calculated by the propulsion subsystem (e.g. take SLS thrust condition from engine deck), and only overridden intentionally by experienced users. Issue #1038 Not moved to Mission.Takeoff. group so as not to confuse with detailed takeoff parameters. This parameter is also independent of the mission to be flown

Related Issues

• Resolves Consolidate the idea of target_range in phase_info and Mission.Design.RANGE #238
• Contributes to Renaming of design vs summary mission variables #772

Backwards incompatibilities

None

New Dependencies

None

[Kenneth-T-Moore]

Yeah, I don't know how this ended up in the variable list.