Skip to content

fix(drivers/cloudreve_v4): remove token check for share #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Suyunmeng merged 2 commits into from
Apr 4, 2026
+11 −0
Merged

fix(drivers/cloudreve_v4): remove token check for share #2274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041bf0c
fix(drivers/cloudreve_v4): remove token check for share
xrgzs Mar 29, 2026
2c3e041
Merge branch 'main' into fix/cloudreve-share
Suyunmeng Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions drivers/cloudreve_v4/driver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ func (d *CloudreveV4) Init(ctx context.Context) error {
if d.ref != nil {
return nil
}
if d.isShare() {
return nil
}
if d.canLogin() {
return d.login()
}
Expand Down
8 changes: 8 additions & 0 deletions drivers/cloudreve_v4/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const (
CodeLoginRequired = http.StatusUnauthorized
CodePathNotExist = 40016 // Path not exist
CodeCredentialInvalid = 40020 // Failed to issue token
// IncorrectSharePassword = 40069 // Incorrect share password
)

var (
Expand Down Expand Up @@ -277,9 +278,16 @@ func (d *CloudreveV4) parseJWT(token string, jwt any) error {
return nil
}

func (d *CloudreveV4) isShare() bool {
return strings.HasSuffix(d.GetRootPath(), "@share")
}

// check if token is expired
// https://github.com/cloudreve/frontend/blob/ddfacc1c31c49be03beb71de4cc114c8811038d6/src/session/index.ts#L177-L200
func (d *CloudreveV4) isTokenExpired() bool {
if d.isShare() {
return false
}
if d.RefreshToken == "" {
// login again if username and password is set
if d.canLogin() {
Expand Down
Loading