Conversation
DaAwesomeP
left a comment
DaAwesomeP
left a comment
There was a problem hiding this comment.
I am a bit confused about the difference between ./configure <args> and DISTCHECK_CONFIGURE_FLAGS, but it is clearly some internal working of Automake.
| @@ -92,11 +92,19 @@ jobs: | |||
| - name: Set configure arguments | |||
| run: | | |||
| echo "GH_OLA_CONFIGURE_ARGS=${{ matrix.configure-args }}" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
Since DISTCHECK_CONFIGURE_FLAGS should always match the arguments to ./configure, what if we just rename GH_OLA_CONFIGURE_ARGS to DISTCHECK_CONFIGURE_FLAGS? When I ported from Travis I didn't realize this was a special env var. We should add a comment about it here.
There was a problem hiding this comment.
Yeah that sounds like it should work. We should probably also backport the comment to the Travis file too.
Do you fancy picking this one up?
There was a problem hiding this comment.
Sure, if that will be faster I can checkout your branch and open a new pull, but it is simple enough to change it here too. Up to you.
| if: runner.os == 'Linux' | ||
| # Silence all deprecated declarations on Linux due to auto_ptr making the build log too long | ||
| run: | | ||
| echo "GH_OLA_CONFIGURE_ARGS=$GH_OLA_CONFIGURE_ARGS CPPFLAGS=-Wno-deprecated-declarations" >> $GITHUB_ENV |
I think the reason is because during distcheck it essentially does: Then on the dist file does: Or something like that. Given the second configure happens as an internal process, you can't tell it what args to use traditionally, and I guess you might want different args for the two configure runs, hence the env var. |
…fix-distcheck-configure Fix CI Java build using correct Autotools env var (closes #1883)
2 participants
No description provided.