Draft
Conversation
All there apart from flags should always be 0xF0 rather than 0x70
…nto e1.33-controller
…nto e1.33-controller
…nto e1.33-controller
…nto e1.33-controller
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realised you might not have got the @mention in my personal repo ( peternewman#43 ) so I'll stick it here too.
This PR would want to go in after #1612 as it's done on top of that.
Please don't actually start reviewing this @kripton , but if you fancy taking a look at it in due course, I was going to break it down a bit to reduce the overall changes of this and https://github.com/OpenLightingProject/ola/pull/1612/files .
Most of the commits add a new PDU each (across three files), do you think there's an optimal number of files/size of commit to split it into for review?
I'll need to cherry-pick to get them into master without just queuing them up behind the existing LLRP stuff, but they should work fine standalone functionally...
Still todo: