Build OpenCL program as soon as the OpenCL device is initialized #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Patch looks very sensible, on what platforms has this been tested so far? |
Contributor
Author
|
I just tested it on Windows |
Contributor
|
Could you merge master into your opencl-build branch again? I don't think this is really a merge conflict, there just have been some minor changes within the OpenCL depth packet processor. |
Before this, the program was built when the first frame arrives and the following frames were dropped, because building the program takes a while. Now, the program is built before the device is started. When the first frame arrives, it only needs to be initialized, which is quite fast.
Contributor
Author
|
Done. It was just one little |
Contributor
|
Finally got around to testing on Ubuntu 14.04, works beautifully. Merged. |
floe
added a commit
that referenced
this pull request
Jul 9, 2015
Build OpenCL program as soon as the OpenCL device is initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the OpenCL program was built when the first frame arrives and the following frames were dropped, because building the program takes a while.
With this change, the OpenCL program is built before the device is started. Then, when the first frame arrives, it only needs to be initialized, which is quite fast.
When the
DepthPacketProcessor::Configchanges, the OpenCL program might need to be re-initialized or even be rebuilt (depending on which config values were changed), but only the config actually changed. This is handled here as well.