Fix a bug with attribute index handling in ModifyAttribute #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes fixes a minor bug with proper attribute index range checking in the server implementation of ModifyAttribute. A corner case that previously slipped through index checking and testing has been closed. An existing unit test has been modified to fix this bug. Partially implements #547
Codecov Report
@@ Coverage Diff @@
## master #613 +/- ##
=========================================
Coverage ? 96.58%
=========================================
Files ? 79
Lines ? 16886
Branches ? 0
=========================================
Hits ? 16310
Misses ? 576
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes fixes a minor bug with proper attribute index range checking in the server implementation of ModifyAttribute. A corner case that previously slipped through index checking and testing has been closed. An existing unit test has been modified to fix this bug.
Partially implements #547