Skip to content

Conversation

@PeterHamilton
Copy link
Contributor

This change adds ModifyAttribute support to the ProxyKmipClient, leveraging the new generic request capability in the underlying KMIPProxy client. New unit tests have been added to cover the new client additions.

Partially implements #547

This change adds ModifyAttribute support to the ProxyKmipClient,
leveraging the new generic request capability in the underlying
KMIPProxy client. New unit tests have been added to cover the new
client additions.

Partially implements #547
@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #608 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   96.54%   96.55%   +<.01%     
==========================================
  Files          79       79              
  Lines       16722    16733      +11     
==========================================
+ Hits        16145    16156      +11     
  Misses        577      577
Impacted Files Coverage Δ
kmip/services/kmip_client.py 71.27% <100%> (+0.24%) ⬆️
kmip/pie/client.py 99.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d283e1...2b38490. Read the comment docs.

@PeterHamilton PeterHamilton merged commit 53308c3 into master Nov 27, 2019
@PeterHamilton PeterHamilton deleted the feat/add-modify-attribute-to-client branch November 27, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants