Update ApplicationSpecificInformation support to modern style #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the ApplicationSpecificInformation attribute implementation to reflect modern library style. Property methods have been added alongside tighter read/write error checking. The unit tests for the attribute have been updated to reflect all of the new changes.
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
- Coverage 96.28% 96.28% -0.01%
==========================================
Files 75 75
Lines 15808 15815 +7
==========================================
+ Hits 15221 15227 +6
- Misses 587 588 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the ApplicationSpecificInformation attribute implementation to reflect modern library style. Property methods have been added alongside tighter read/write error checking. The unit tests for the attribute have been updated to reflect all of the new changes.