Skip to content

Conversation

@PeterHamilton
Copy link
Contributor

This change updates Locate operation support in the PyKMIP server, allowing users to filter objects using the offset and maximum item constraints. The offset constraint tells the server how many matching items should be skipped before results are returned. The maximum items constraint tells the server how many matching items should be returned. Unit tests and integration tests have been added to test and verify the correctness of this feature.

Additionally, the Locate demo scripts have also been updated to support offset and maximum item filtering. Simply use the "--offset-items" and "--maximum-items" flags to specify offset and maximum item values for the Locate script to filter on.

Fixes #562

This change updates Locate operation support in the PyKMIP server,
allowing users to filter objects using the offset and maximum item
constraints. The offset constraint tells the server how many
matching items should be skipped before results are returned. The
maximum items constraint tells the server how many matching items
should be returned. Unit tests and integration tests have been
added to test and verify the correctness of this feature.

Additionally, the Locate demo scripts have also been updated to
support offset and maximum item filtering. Simply use the
"--offset-items" and "--maximum-items" flags to specify offset and
maximum item values for the Locate script to filter on.

Fixes #562
@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@4938f82). Click here to learn what that means.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #575   +/-   ##
=========================================
  Coverage          ?   96.01%           
=========================================
  Files             ?       75           
  Lines             ?    15470           
  Branches          ?        0           
=========================================
  Hits              ?    14854           
  Misses            ?      616           
  Partials          ?        0
Impacted Files Coverage Δ
kmip/services/kmip_client.py 69.89% <ø> (ø)
kmip/services/server/engine.py 99.31% <100%> (ø)
kmip/pie/client.py 99.36% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4938f82...bfd2cf7. Read the comment docs.

@PeterHamilton PeterHamilton merged commit 4a6a2ec into master Aug 9, 2019
@PeterHamilton PeterHamilton deleted the feat/add-offset-max-items-to-locate branch August 9, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locate function does not handle offset.

3 participants