refactor: Factoring specification revision and extensions out of Model… #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baxeaz
changed the title
…lParsingContextInterface into a public data class for use in evaluating supported behaviors and capabilities. Signed-off-by: Brian Axelson <86568017+baxeaz@users.noreply.github.com>
|
mwiebe
approved these changes
May 21, 2025
crowecawcaw
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We want a class for representing a specification version and extensions for the purposes of evaluating OpenJD behaviors and capabilities.
What was the solution? (How)
Factor spec_rev and extensions out of ModelParsingContextInterface into a new public RevisionExtensions class which internally ModelParsingContextInterface uses.
What is the impact of this change?
Currently no impact, will use RevisionExtensions in other PRs.
How was this change tested?
Re ran unit tests in openjd-model-for-python, used class in a different in progress PR in openjd-sessions-for-python and ran unit tests.
Yes
Was this change documented?
Yes
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.