feat: Adding support for redacted environment variable values through… #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… openjd_redacted_env Signed-off-by: Brian Axelson <86568017+baxeaz@users.noreply.github.com>
|
joel-wong-aws
approved these changes
May 16, 2025
crowecawcaw
approved these changes
May 16, 2025
mwiebe
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We want to support the new openjd_redacted_env keyword in openjd when a new extension (REDACTED_ENV_VARS) is enabled as part of OpenJobDescription/openjd-specifications#86.
In testing it was discovered that unit tests in openjd-cli were broken due to a few class definitions being out of order and having ForwardRef annotations in place.
What was the solution? (How)
Add the extension definition and a basic test.
Reorder the class definitions which were out of order.
Add a test that looks through all of our _model classes to ensure there are no forward references.
What is the impact of this change?
Unit tests in openjd-cli should pass again.
We can add the other PRs to support the env var redaction feature.
How was this change tested?
All tests pass.
Ran openjd-cli tests with the fix successfully.
Ran the test with the old order and saw the expected failure.
New test that runs with expected forward reference catches it successfully.
Was this change documented?
Yes
Is this a breaking change?
No
Does this change impact security?
No - the related changes to openjd-sessions-for-python do, but this is just declaring the name of an extension.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.