Skip to content

Conversation

@mwiebe
Copy link
Contributor

@mwiebe mwiebe commented Feb 10, 2025

What was the problem/requirement? (What/Why)

The CLI depends on some implementation details of Pydantic V1 that have changed in V2. Need to update to match OpenJobDescription/openjd-model-for-python#164.

What was the solution? (How)

Modify the code to work with the Pydantic V2 openjd-model.

What is the impact of this change?

The CLI will continue to work after the Pydantic V2 upgrade

How was this change tested?

  • Have you run the tests?

Yes

Was this change documented?

N/A

Is this a breaking change?

No, nothing about the CLI interface is changing.

This is an update to match a breaking change in the openjd-model library. That change is breaking because its interface is based on Pydantic, so code that depends on details that differ in V2 need to be updated.

Does this change impact security?

  • Does the change need to be threat modeled? For example, does it create or modify files/directories that must only be readable by the process owner?
    • If so, then please label this pull request with the "security" label. We'll work with you to analyze the threats

No security impacts.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@epmog epmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once the new model version is released we can update the PR.

I'd bias towards not a breaking change for this since it's an application that isn't changing as opposed to the library usage. But I won't die on that hill.

@mwiebe mwiebe changed the title chore!: Update to use openjd-model based on Pydantic V2 instead of Pydantic V1 chore: Update to use openjd-model based on Pydantic V2 instead of Pydantic V1 Feb 14, 2025
@mwiebe mwiebe changed the title chore: Update to use openjd-model based on Pydantic V2 instead of Pydantic V1 feat: Update to use Pydantic V2 and enable chunking Feb 20, 2025
@mwiebe mwiebe force-pushed the pydantic2 branch 2 times, most recently from 67b2c8e to c465a27 Compare February 25, 2025 20:18
@mwiebe mwiebe marked this pull request as ready for review February 25, 2025 20:19
@mwiebe mwiebe requested a review from a team as a code owner February 25, 2025 20:19
Signed-off-by: Mark Wiebe <399551+mwiebe@users.noreply.github.com>
@sonarqubecloud
Copy link

@mwiebe mwiebe enabled auto-merge (rebase) February 26, 2025 00:19
@mwiebe mwiebe merged commit c683738 into OpenJobDescription:mainline Feb 26, 2025
19 checks passed
@mwiebe mwiebe deleted the pydantic2 branch February 26, 2025 00:20
@moorec-aws moorec-aws mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants