Update locale attribute names for Diplomat locale-based labels#757
Update locale attribute names for Diplomat locale-based labels#757Rub21 wants to merge 8 commits into
Conversation
| 'NULL::double precision AS min_height', | ||
| 'NULL::double precision AS building_height', | ||
| 'NULL::double precision AS roof_height', | ||
| 'NULL::text AS building_min_level', |
There was a problem hiding this comment.
building:min_level=* is also an integer.
| ARRAY[ | ||
| 'NULL::double precision AS height', | ||
| 'NULL::double precision AS min_height', | ||
| 'NULL::double precision AS building_height', |
There was a problem hiding this comment.
building:height=* is deprecated in favor of height=*. I just eliminated the last occurrence in the database.
| result := ft * 0.3048; | ||
| -- meters (default or explicit): 20 / 20.5 / 20 m / 20m / 20 meters | ||
| ELSIF s ~* '^-?\d+(\.\d+)?\s*(m|meter|meters)?$' THEN | ||
| m := regexp_replace(s, '\s*(m|meter|meters)\s*$', '', 'i'); |
There was a problem hiding this comment.
The meter and meters symbols are discouraged. We only had one occurrence, which I’ve eliminated.
| result := (ft * 0.3048) + (inch * 0.0254); | ||
| -- feet with ft suffix: 85ft / 85 ft / 85.5 ft | ||
| ELSIF s ~* '^\d+(\.\d+)?\s*ft$' THEN | ||
| ft := regexp_replace(s, '\s*ft$', '', 'i')::numeric; |
| result := (ft * 0.3048) + (inch * 0.0254); | ||
| -- feet with ft suffix: 85ft / 85 ft / 85.5 ft | ||
| ELSIF s ~* '^\d+(\.\d+)?\s*ft$' THEN | ||
| ft := regexp_replace(s, '\s*ft$', '', 'i')::numeric; |
There was a problem hiding this comment.
The documentation discourages ft, and we don’t currently have any occurrences in the database. OSM’s U.S. community has frequently discussed making it acceptable again, but for now, 8' is much more common. If we support it, we should probably support 8 ft 5 in too.
| { | ||
| "type": "string", | ||
| "name": "building_part", | ||
| "key": "building:part" | ||
| }, |
There was a problem hiding this comment.
Unlike all the other keys, building:part=* does not require building=*. It represents a different kind of feature. For example, this dome doesn’t appear in the staging tiles. We can include building parts in the buildings layer for convenience, rather than a separate layer as suggested in OpenHistoricalMap/issues#1370, but we’d need a boolean attribute indicating that it’s a building part.
In other tile schemas that expose building parts, a building outline has an attribute that tells the stylesheet not to extrude it in 3D. This attribute would appear on any building=* area that contains building parts or that has the role outline in a building relation. Without this attribute, the extruded building outline would obscure any building parts within it.
2 participants
I made some changes that require an imposm re-import, so I am considering to solve those issues in this PR: