Re: https://github.com/OpenHistoricalMap/issues/issues/877#231
Re: https://github.com/OpenHistoricalMap/issues/issues/877#231erictheise wants to merge 4 commits intostagingfrom
Conversation
…m to ensure id.min.js is generated
… is done by upstream (hotosm)
There was a problem hiding this comment.
Should the minified build artifact be checked into staging? Upstream only does that in a release branch, not in the develop branch, equivalent to our staging branch.
There was a problem hiding this comment.
Yes it should.
Since we are pulling it in to HOT's tasking-manager where it's consumed as an npm module where we need to look is in their fork of iD. https://github.com/hotosm/iD/tree/2.x/dist
My dev server will not load without it.
There was a problem hiding this comment.
This may make future merges with upstream iD more error-prone. Can we merge staging into https://github.com/OpenHistoricalMap/iD/tree/release, build these artifacts there, and publish them to NPM, as iD does?
Edit: Looks like we’ve already checked in some of the built artifacts but not the minified version. I see how that would be a problem, but ideally we would keep both dist/iD.js and dist/iD.min.js out of staging.
2 participants
Pull eslit.config.mjs from upstream to ensure id.min.js is generated