Update source prerequisite behavior#226
Open
pedromml wants to merge 2 commits intoOpenHistoricalMap:stagingfrom
Open
Update source prerequisite behavior#226pedromml wants to merge 2 commits intoOpenHistoricalMap:stagingfrom
pedromml wants to merge 2 commits intoOpenHistoricalMap:stagingfrom
Conversation
1ec5
reviewed
Oct 15, 2024
Member
1ec5
left a comment
1ec5
left a comment
There was a problem hiding this comment.
This looks good at a glance. Could you add a test of this functionality? It would probably be similar to one of the tests you wrote in source_subfield.js. Thanks!
modules/presets/index.js
Outdated
Comment on lines
75
to
76
| let sourceRegex = /^source/; | ||
| if (tag.match(sourceRegex) ){ |
Member
There was a problem hiding this comment.
Suggested change
| let sourceRegex = /^source/; | |
| if (tag.match(sourceRegex) ){ | |
| if (tag.startsWith('source')) { |
Open
4 tasks
|
@1ec5 I assume based on your comment that this is not ready to merge? |
Author
|
I've been working on tests for this behavior for a while, more specifically for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the behavior of multiple source fields. Now, a Source i will be visible if
source:i-1has a non-empty value, or if any source tag with index > i has a non-empty value.This will ensure all Source fields from 1 to 3 to be visible if
source:3has a non-empty value