Add multiple source fields

[pedromml]

This PR implements multiple source fields.
To use them, a user first has to write something in any of the inputs in the first "Source" field, then go to Add field -> Source 2. If something is written in any "Source 2" input, the user will be able to add "Source 3", and so on up to "Source 4".
The first source field will still be mapped to source=* / source:name=* , while the next source fields will be mapped to source:2=* / source:2:name=*

[1ec5]

This is good to go as soon as the localization issues are resolved. Thanks!

[1ec5]

This still needs to be localized. You can define a format string in the localization and pass in the number as a parameter to replace the token in the format string:

iD/data/core.yaml

Lines 766 to 767 in cb779ea

	# format for the label of a feature that has a name and date range
	dated: "{name} [{dateRange}]"

iD/modules/util/util.js

Line 5 in cb779ea

import { t, localizer } from '../core/localizer';

iD/modules/util/util.js

Line 219 in cb779ea

return dateRange ? t('inspector.display_name.dated', {dateRange: dateRange, name: name}) : name;

/ref #224

[1ec5]

Minor: String.prototype.toString() is suitable for Western languages, but not for some other languages we support, like Persian. Number.prototype.toLocaleString automatically adapts the number to the given writing system. Fortunately, you can just pass a number into the t function and it’ll do the right thing.

[pedromml]

This String.prototype.toString() is being used to define the source:2 key. If the "2" is localized, couldn't that cause problems? With the key ending up like source:٢

[1ec5]

Oh, you’re right, you’re only appending i to “Source” below. So as long as you pass i into the t() call for that field name, it should work fine.

[1ec5]

Thanks, looks good!