fix(sdk): lock litellm.modify_params around completion calls#3249
Open
nehaaprasaad wants to merge 1 commit into
Open
fix(sdk): lock litellm.modify_params around completion calls#3249nehaaprasaad wants to merge 1 commit into
nehaaprasaad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Concurrent
LLMcompletions read/write LiteLLM’s globalmodify_paramswithout synchronization; one thread’s restore could overwrite another’s active value mid-call.Summary
_litellm_modify_params_lockinopenhands-sdk/openhands/sdk/llm/llm.py.yield/ restore in_litellm_modify_params_ctxwith that lock so chat and responses paths stay consistent under threads.Issue Number
Closes #3137
How to Test
From repo root:
make buildthenuv run pytest tests/sdk/llm/ -qanduv run pre-commit run --files openhands-sdk/openhands/sdk/llm/llm.py.Video/Screenshots
N/A (no UI).
Type