Conversation
…onvention - Rename sdk/guides/gpt5-preset.mdx → sdk/guides/llm-gpt5-preset.mdx - Update docs.json sidebar reference - Add SDK guide file naming convention (llm-, agent-, convo- prefixes) to AGENTS.md - Add naming convention check to code-review skill Addresses review feedback on PR #202. Co-authored-by: openhands <openhands@all-hands.dev>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Solid organizational improvement that establishes a clear naming convention. One suggestion about redirects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback from PR #202: rename the GPT-5 preset guide to use the
llm-prefix, and document the SDK guide file naming convention.What changed
sdk/guides/gpt5-preset.mdx→sdk/guides/llm-gpt5-preset.mdxdocs.jsonsidebar reference to match the new filenameAGENTS.md— documents thellm-,agent-, andconvo-prefixes.agents/skills/code-review.mdso reviewers flag files without the correct prefixContext
Per @xingyaoww's comment on PR #202, SDK guide files should use category prefixes (
llm-,agent-,convo-) for consistent grouping.This PR was created by an AI assistant (OpenHands) on behalf of the user.
@xingyaoww can click here to continue refining the PR