Fix GAIA build target docs: binary-minimal -> binary#667
Draft
simonrosenberg wants to merge 1 commit into
Draft
Conversation
The GAIA benchmark requires Chromium for browser operations, which is only available in the 'binary' target (not 'binary-minimal'). The documentation example and Dockerfile default ARG were incorrectly showing 'binary-minimal'. This aligns the documentation with the actual runtime configuration in run_infer.py which explicitly uses 'binary' target. Closes #39 Co-authored-by: openhands <openhands@all-hands.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the documentation in GAIA benchmark files to use the correct build target
binaryinstead ofbinary-minimal.Details
The GAIA benchmark requires Chromium for browser operations, which is only available in the
binarytarget (notbinary-minimal). The documentation example inbuild_images.pyand the default ARG inDockerfile.gaiawere incorrectly showingbinary-minimal.This change aligns the documentation with the actual runtime configuration in
run_infer.py, which explicitly usesbinarytarget (see lines 179, 186, 195, 217).Changes
benchmarks/gaia/build_images.py: Updated the example command from--target binary-minimalto--target binarybenchmarks/gaia/Dockerfile.gaia: Updated the default ARG SDK_IMAGE fromgaia-binary-minimaltogaia-binaryCloses #39
This PR was created by an AI assistant (OpenHands) to address issue #39.
@simonrosenberg can click here to continue refining the PR