Remove redundant 'Apply workflow_dispatch overrides' step from build workflows#660
Draft
simonrosenberg wants to merge 1 commit into
Draft
Remove redundant 'Apply workflow_dispatch overrides' step from build workflows#660simonrosenberg wants to merge 1 commit into
simonrosenberg wants to merge 1 commit into
Conversation
…workflows
Replace hardcoded env defaults with `${{ inputs.X || 'default' }}` expressions
so both workflow_dispatch and pull_request_target triggers work without a
separate override step.
For pull_request_target events, inputs are empty so the fallback applies.
For workflow_dispatch events, the input value is used directly.
Also removes unused env vars (BUILD_BATCH_SIZE, BUILDKIT_PRUNE_KEEP_GB,
BUILDKIT_PRUNE_THRESHOLD_PCT) from workflows where they were defined but
never referenced.
Fixes #565
Co-authored-by: openhands <openhands@all-hands.dev>
74022ea to
7f48ef8
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the redundant "Apply workflow_dispatch overrides" step from build workflows by replacing hardcoded env defaults with
${{ inputs.X || 'default' }}expressions.Fixes #565
Changes
Pattern Applied
Before:
After:
This works because:
workflow_dispatch: the input value is used directlypull_request_target: inputs are empty so the||fallback appliesWorkflows Updated
.github/workflows/build-swebench-images.yml.github/workflows/build-commit0-images.yml.github/workflows/build-multiswebench-images.yml.github/workflows/build-swebenchmultimodal-images.yml.github/workflows/build-swegym-images.yml.github/workflows/build-swesmith-images.ymlAdditional Cleanup
Also removes unused env vars that were defined but never referenced:
BUILD_BATCH_SIZEBUILDKIT_PRUNE_KEEP_GBBUILDKIT_PRUNE_THRESHOLD_PCTThese were present in
build-multiswebench-images.yml,build-swegym-images.yml, andbuild-swesmith-images.yml.Testing
This is a workflow configuration change. The behavior should be equivalent for both trigger types:
This PR was created by an AI assistant (OpenHands) on behalf of the user.
@simonrosenberg can click here to continue refining the PR