-
Notifications
You must be signed in to change notification settings - Fork 65
Filter SWE-Bench Multimodal image builds to curated subset #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juanmichelini
wants to merge
7
commits into
main
Choose a base branch
from
openhands/fix-swebenchmultimodal-build-subset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
51c7ac3
Filter SWE-Bench Multimodal image builds to curated subset
openhands-agent 12f0a33
Fix workflow to use curated subset by default in SELECT_FILE env var
openhands-agent 4016542
Merge origin/main into openhands/fix-swebenchmultimodal-build-subset
openhands-agent fa64c29
Fix SELECT_FILE not being passed to build_images.py
openhands-agent 2fce312
Merge remote-tracking branch 'origin/main' into openhands/fix-swebenc…
openhands-agent fc690eb
Merge main: sync dependencies and incorporate new benchmark changes
openhands-agent bec24c3
Merge main: address review feedback & resolve test conflict
openhands-agent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -83,14 +83,25 @@ on: | |
| type: string | ||
|
|
||
| # Defaults for automatic runs; keep INSTANCE_IDS/SELECT_FILE initialized so set -euo pipefail won't fail on unset vars. | ||
| # | ||
| # NOTE (behavior change introduced alongside curated-subset inference defaults): | ||
| # SELECT_FILE now defaults to `resolved_instances.txt`, so by default this | ||
| # workflow only builds the curated 68-instance subset (the same subset used by | ||
| # `swebenchmultimodal-infer`). This matches the inference default and avoids | ||
| # burning CI time on instances we never evaluate. | ||
| # | ||
| # To build the FULL dataset, manually trigger the workflow and either: | ||
| # * provide explicit `instance-ids`, or | ||
| # * clear SELECT_FILE in your fork (e.g. set this env to ''). | ||
| # Without one of those overrides, only the 68 curated instances will be built. | ||
| env: | ||
| DATASET: princeton-nlp/SWE-bench_Multimodal | ||
| SPLIT: dev | ||
| MAX_WORKERS: '8' | ||
| MAX_RETRIES: '2' | ||
| N_LIMIT: '500' | ||
| INSTANCE_IDS: '' | ||
| SELECT_FILE: '' | ||
| SELECT_FILE: ${{ github.workspace }}/benchmarks/swebenchmultimodal/resolved_instances.txt | ||
|
|
||
| concurrency: | ||
| group: build-swe-bench-multimodal-${{ inputs.sdk-commit || github.ref }} | ||
|
|
@@ -172,6 +183,14 @@ jobs: | |
| with: | ||
| instance-ids: ${{ env.INSTANCE_IDS }} | ||
|
|
||
| # Debug: Print SELECT_FILE value before building | ||
| - name: Debug SELECT_FILE | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Suggestion — Remove debug step before merging: This step was useful during development but adds noise to every production CI run. Consider either:
The step itself is harmless, but leftover debug output creates log clutter that can distract from real failures. |
||
| run: | | ||
| echo "SELECT_FILE=${SELECT_FILE}" | ||
| if [ -n "${SELECT_FILE}" ] && [ -f "${SELECT_FILE}" ]; then | ||
| echo "SELECT_FILE exists with $(wc -l < "${SELECT_FILE}") lines" | ||
| fi | ||
|
|
||
| # Update SDK submodule to specific commit if provided | ||
| # Must run BEFORE install dependencies so git submodule update works correctly | ||
| - name: Update SDK submodule | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.