ohttp registry changes#58
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
adambalogh
reviewed
May 25, 2026
| string calldata endpoint, | ||
| uint8 teeType | ||
| ) external onlyRole(TEE_OPERATOR) returns (bytes32 teeId) { | ||
| ) public virtual onlyRole(TEE_OPERATOR) returns (bytes32 teeId) { |
Contributor
There was a problem hiding this comment.
what's the plan with this? do you wanna set up a new v1 contract too? in that case why not just add the OHTTP stuff to this file?
or keep the old one? in that case, this wouldn't work no since the bytecode is different?
Collaborator
Author
There was a problem hiding this comment.
i just changed it so that the new registry contract can call the function internally, the old registry would be deprecated and the new registry one would have both functions
adambalogh
reviewed
May 25, 2026
| /// @notice Set or rotate the OHTTP config for a registered TEE. | ||
| /// @dev The caller must own the TEE or be an admin, and the config must be | ||
| /// signed by the TEE signing key stored in the base registry. | ||
| function setOHTTPConfig( |
Contributor
There was a problem hiding this comment.
what's the use-case for this? we wouldn't expect ohttp keys to change over the lifetime of a TEE no?
adambalogh
reviewed
May 25, 2026
adambalogh
reviewed
May 25, 2026
Contributor
|
Add unit tests please |
adambalogh
reviewed
May 27, 2026
adambalogh
reviewed
May 27, 2026
dixitaniket
added
run-ci
dixitaniket
added
run-ci
dixitaniket
added
run-ci
dixitaniket
added
run-ci
dixitaniket
added
run-ci
…p-updates # Conflicts: # contracts/solidity/TEERegistry.sol # tests/solidity/suites/tee/contracts/MockTEERegistry.sol # tests/solidity/suites/tee/test/registry.js
added 2 commits
May 27, 2026 13:58
…p-updates # Conflicts: # tests/solidity/suites/tee/test/registry.js
adambalogh
added
run-ci
added 2 commits
May 27, 2026 14:22
adambalogh
added
run-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
More Details
Testing