Add config option to include drop fixes#313
Add config option to include drop fixes#313FinnHornhoover wants to merge 3 commits intoOpenFusionProject:masterfrom
Conversation
config.ini
Outdated
|
|
||
| # should drop fixes be enabled? | ||
| # this includes changes that fix stuff like Fusionfly and Freakosaurus Rex drops | ||
| # and also fix Academy-specific mobs with no drops |
There was a problem hiding this comment.
I would re-word this to clarify what exactly "fix" means. Something like: "This adds drops to mobs that previously didn't have any or drops that weren't in the drop table. This is polish that is slightly inauthentic to the original game."
There was a problem hiding this comment.
Much clearer, thanks!
src/settings.cpp
Outdated
| if (ENABLEDPATCHES.empty()) { | ||
| ENABLEDPATCHES = "0104-fix"; | ||
| } else { | ||
| ENABLEDPATCHES += " 0104-fix 1013-fix"; |
There was a problem hiding this comment.
nit: I would rename these to 0104-fixes to make it extra clear that this is a plurality of miscellaneous adjustments; especially if we keep adding to these patches in the future.
There was a problem hiding this comment.
Done, makes sense.
yungcomputerchair
left a comment
yungcomputerchair
left a comment
There was a problem hiding this comment.
Approved with strong suggestion
src/settings.cpp
Outdated
| if (ENABLEDPATCHES.empty()) { | ||
| ENABLEDPATCHES = "0104-fixes"; | ||
| } else { | ||
| ENABLEDPATCHES += " 0104-fixes 1013-fixes"; |
There was a problem hiding this comment.
I would strongly prefer if you explicitly check for 1013 in the enabled patches string before adding the 1013 patches
4 participants
In the OpenFusionProject/tabledata#24 PR, we've refactored certain convenient drop fixes to their own patches. This PR is to allow these patches to be included easier with
config.inioptions.