Skip to content

Add SepTop example script#115

Open
hannahbaumann wants to merge 9 commits intomainfrom
plan_septop
Open

Add SepTop example script#115
hannahbaumann wants to merge 9 commits intomainfrom
plan_septop

Conversation

@hannahbaumann
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread openfe_benchmarks/scripts/_example_plan_rbfe.py Outdated
Comment thread openfe_benchmarks/scripts/_example_plan_rbfe.py Outdated
@hannahbaumann hannahbaumann changed the title [WIP] Add SepTop example script Add SepTop example script Mar 18, 2026
@hannahbaumann hannahbaumann requested a review from jthorton March 18, 2026 16:19
# adaptive transformation settings are only supported for RelativeHybridTopologyProtocol currently
protocol_settings = RelativeHybridTopologyProtocol.default_settings()
protocol_settings.forcefield_settings.small_molecule_forcefield = FORCEFIELD
protocol_settings.protocol_repeats = 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this!

Comment thread openfe_benchmarks/scripts/_example_plan_septop.py
transformation = openfe.Transformation(
stateA=system_a,
stateB=system_b,
mapping=None,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the mapping for this protocol, but could we include it with the system_group and system_name, like we do in _example_plan_rbfe.py, so we can track which systems the edge corresponds to?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm not quite sure what you mean here, could you maybe clarify?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll keep the mapping for now, opening an issue in gufe to allow adding annotations to Transformations, will revisit after gufe decision.

componentA=ligands_by_name[edge.componentA.name],
componentB=ligands_by_name[edge.componentB.name],
componentA_to_componentB=edge.componentA_to_componentB,
annotations=edge.annotations,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can keep the mapping lets track the system_group and system_name in the annotations field for the new edge.

transformation = openfe.Transformation(
stateA=system_a,
stateB=system_b,
mapping=None,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mapping=None,
mapping=new_edge,

@jthorton is this what you meant here? This is what the plan rbfe script does.

@hannahbaumann hannahbaumann requested a review from jthorton April 23, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants